BitHeaven/picom
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,189 Commits 1 Branch 0 Tags
3060fe8f2cb4c2db4a82d4b038019e1b0609741c
Commit Graph

1189 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
yshui
3060fe8f2c Merge pull request #235 from liskin/readme-deps 
README: fix typo in debian deps
 2019-09-20 01:28:03 +00:00
Tomas Janousek
90c71a7014 README: fix typo in debian deps 2019-09-19 16:02:44 +02:00
Yuxuan Shui
de5d5ca9bb event.c: run clang-format 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-09-16 23:28:16 +01:00
Yuxuan Shui
48687b985d Make potentially window destroying functions take simple pointers 
Instead of pointer to pointer. The two level of pointers were used to
inform the caller the window has been destroyed (pointer set to NULL).

Now, destruction of windows are now signaled by the return value, which
is marked `must_use`.

Problem with taking pointer to pointer is that they tends to pollute the
function signatures a little bit. And we are not using it well anyways.
A lot of the callers passes pointers to local variables to those
functions, so the information about window destruction doesn't actually
bubble up. So, we switch to use just one level of pointers instead.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-09-16 23:14:03 +01:00
Yuxuan Shui
127b1ac3a4 win: remove some unreachable code 
finish_destroy_win has unreachable code after a return statement

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-09-16 22:46:25 +01:00
Yuxuan Shui
1780f63914 backend/driver.h: add comments about NVIDIA quirks 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-09-16 22:44:09 +01:00
Yuxuan Shui
b2ff4eb2c9 compiler.h: add popcount 2019-09-07 19:11:04 +01:00
Yuxuan Shui
4e915837a4 core: track whether server is grabbed 2019-09-07 19:10:58 +01:00
Yuxuan Shui
02139b7c9f Fix type in log message 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-27 22:15:36 +01:00
yshui
50a2b51f57 Merge pull request #226 from wxl/next 
added keywords to desktop entry
 2019-08-19 22:49:13 +01:00
Walter Lapchynski
92e005fe0d added keywords to desktop entry 2019-08-18 20:59:47 -07:00
Yuxuan Shui
d6added769 README: add Ubuntu specific package names 
It could be hard for Ubuntu/Debian users to find the correct packages
for the dependencies.

Thanks @kgilmer

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-18 22:39:18 +01:00
Yuxuan Shui
05d4d04a33 issue template: use proper html comment 
This way the report doesn't have to remove the comments in the template.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-18 01:34:18 +01:00
Yuxuan Shui
04520368f6 glx: clarify a comment 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-11 03:24:02 +01:00
Yuxuan Shui
0771234ee2 More header fixes 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-10 15:31:23 +01:00
Yuxuan Shui
2fbb45dcd7 win: remove unused member of struct win 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-10 01:47:05 +01:00
Yuxuan Shui
306f5e8b75 win.h: remove unused prototypes 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-10 01:44:27 +01:00
Yuxuan Shui
dd21806662 core: shrink the critical section in session_init 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-10 01:23:11 +01:00
Yuxuan Shui
0ba7761bd5 Untangle headers 
Thanks, clang -fmodules.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-10 00:56:26 +01:00
Yuxuan Shui
a01ec1ec94 Update .gitignore 2019-08-09 23:40:41 +01:00
Yuxuan Shui
bc60e06e23 Fix example dbus script after TYPE_ENUM change 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-09 23:40:20 +01:00
Yuxuan Shui
fae30d46e7 core: don't initialize dbus in critical section 
grabbing X server stops the dbus daemon in some cases, causing compton to
hang in dbus initialization.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-09 23:34:37 +01:00
Yuxuan Shui
c719804fb1 backend: dummy: initialize backend_base properly 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-09 23:33:01 +01:00
Yuxuan Shui
c8d6a5cae5 tests: print compton log after tests finish 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-05 00:05:23 +01:00
Yuxuan Shui
4dc5a04735 core: fix background not blurred under transparent windows 
When a window has 0 opacity, it's rendering is skipped completely. Thus
its background isn't blurred.

This commit fixes that.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-04 23:15:10 +01:00
Yuxuan Shui
78f002d154 Run test cases in CI 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-04 21:10:49 +01:00
Yuxuan Shui
6bc8cfc3ce Add very simple test cases 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-04 19:50:34 +01:00
Yuxuan Shui
9b419ce37d core: fix assertion failure when blur context failed to initialize 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-04 17:55:39 +01:00
Yuxuan Shui
8eb9d07fa8 Add dummy backend 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-04 17:52:45 +01:00
Yuxuan Shui
d702fc9365 Preparation for dummy backends 
Dummy backends are backends that doesn't render anything on to the
screen or the target window. But they are still be useful for debug
purposes, and can be useful for other things too.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-04 16:46:09 +01:00
Yuxuan Shui
8168c38d4f core: no need to unredirect the registration window 
This window is invisible anyway, whether it's redirected should be
inconsequential.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-04 16:41:28 +01:00
Yuxuan Shui
c305d67a62 Vendor test.h 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-04 13:49:28 +01:00
Yuxuan Shui
ddde118c69 core: check if a chosen backend is available 
Error out instead of segfaulting when the chosen backend is not
available.

Fixes #210

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-08-01 21:23:56 +01:00
Yuxuan Shui
1f80c8dc16 render: don't free blur_kerns_cache when it's not used 
blur_kernel_count could be none zero when user set a blur kernel but
didn't enable blur. In that case deinit_render will try to free
elements of blur_kerns_cache, causing a segfault because
blur_kerns_cache is never allocated.

Fixes #209

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-31 23:52:31 +01:00
Yuxuan Shui
ea6f355a6b meson.build: make git version string less confusing 
compton built from the git repo often _seems_ to be from a older release,
this change disambiguate the version string.

compton built from the git repo now have version string like this:
'vgit-xxxxx'

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-30 22:22:21 +01:00
Yuxuan Shui
6cb5f9711e core: deregister xerror handler in session_destroy 
xerror handler might be called during XCloseDisplay, at which point
session_t is already destroyed, causing a segfault.

Ping #209

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-30 06:40:24 +01:00
Yuxuan Shui
d7415fcf2e new backends: blur background before rendering shadow 
Otherwise the blurred background will have a darker edge because the
shadow is blended in.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-29 21:19:06 +01:00
Yuxuan Shui
5da71e6bfd core: add a TODO 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-27 17:08:47 +00:00
Yuxuan Shui
6ac50626ef win: don't create shadow image when not requested 
win_set_shadow tries to create shadow image even when shadow_new is false, this
is incorrect.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-27 00:02:44 +01:00
Yuxuan Shui
a229f34eaa new backend: fix background blur of window with opacity set 
Only render blur with transparency when window is fading in/out.
Otherwise, a window with a set opacity will always have a completely
blurred background.

Fixes #198

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 23:43:28 +01:00
Yuxuan Shui
79fc36b3e3 win: don't change window OPACITY property 
Don't override the OPACITY property set by the user on the window.

Fixes #134

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 22:29:42 +01:00
Yuxuan Shui
3434ea25f4 new xrender: fix nothing gets rendered without vsync 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 20:25:17 +01:00
Yuxuan Shui
c7bb6b0fe3 Clarify some of the backend interface functions 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 18:32:39 +01:00
Yuxuan Shui
e3b93a4f84 Additional blur artifact fix 
There were still some artifacts left when multiple semi-transparent
windows are stacked on top of each other.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 18:28:22 +01:00
Yuxuan Shui
0109fe181e gl_common: fix memory leak in _gl_fill 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 03:53:24 +01:00
Yuxuan Shui
4772103334 Remove some unused members of session_t 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 03:39:01 +01:00
Yuxuan Shui
357968c815 options: remove a spurious warning 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 02:44:42 +01:00
yshui
04ae6934e1 Merge pull request #206 from yshui/fix-blur-artifacts 
Fix blur artifacts in experimental backends

Closes #194 #50
 2019-07-26 02:34:06 +01:00
Yuxuan Shui
d37a4136ee new xrender: implement partial updates 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 02:31:45 +01:00
Yuxuan Shui
5a861d5d6a gl_common, new glx: implement partial updates 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-07-26 02:22:05 +01:00