Commit Graph

23 Commits

Author SHA1 Message Date
Kristian Setälä 3469f5ce28 Merge pull request #1 from selurvedu/master
Support symbol strings with '_' in place of '+'
2015-08-02 21:04:24 +03:00
selurvedu 2602e1710f Fix issues found by Cppcheck
These include:

  - [X11Exception.h:16]: Class 'X11Exception' has a constructor
    with 1 argument that is not explicit.

  - [wrapper.cpp:62]: Array index 'i' is used before limits check.

  - [wrapper.cpp:183]: Exception should be caught by reference.
2015-07-27 22:02:07 +00:00
selurvedu 7d5c44d4c4 Trim unwanted bracket in layout name 2015-07-27 21:11:13 +00:00
selurvedu 58fa6eb1f9 Support symbol strings with '_' in place of '+'
This fixes a segfault that occurs for the following reason:

 - In XKeyboard::initializeXkb(), the XkbSymbolParser::parse() is called
   with three arguments - string to process (symName),
   vector to push symbol names to (_symbolNames)
   and vector to push variant names to (_variantNames).

 - In XkbSymbolParser::parse(), it looks for char '+' in symName string,
   but Xkb may use '_' instead when creating that string. If the char
   is not found, parse() doesn't append anything to vectors and they
   remain empty.

 - Later, XKeyboard::initializeXkb() tries to access nonexistent data in
   _symbolNames, which causes a segmentation fault (on lines 162-163).
2015-07-20 01:05:59 +03:00
Kristian Setälä 552ba9856f Wording 2010-01-08 15:31:15 +02:00
Kristian Setälä 60c7e38b6e Added a somewhat non-automatic dist target 2010-01-07 22:50:07 +02:00
Kristian Setälä 353828cf8e A small README fix 2010-01-07 22:41:36 +02:00
Kristian Setälä 4b86cba43d Remove extra paragraphs from the list 2010-01-07 22:39:25 +02:00
Kristian Setälä bbfd1e255c README tweaks 2010-01-07 22:31:35 +02:00
Kristian Setälä 7ea6c20d97 Missin rparen 2010-01-07 22:26:00 +02:00
Kristian Setälä 3c6ed2cb47 Added code to validate arg for the set command 2010-01-07 22:23:02 +02:00
Kristian Setälä 8a651b063f A new README file 2010-01-07 22:03:45 +02:00
Kristian Setälä fafaa71e6d -p, -s => print, set; error on incorrect format tag 2010-01-07 22:01:36 +02:00
Kristian Setälä ee21b5b37d .gitignore is back... 2010-01-07 22:00:38 +02:00
Kristian Setälä 17eae4b2a8 Changed commands '-p' and '-s' to 'print' and 'set' 2010-01-07 20:32:06 +02:00
Kristian Setälä 5fd399a610 ...and removed .gitignore =} 2010-01-02 23:28:09 +02:00
Kristian Setälä 091b5ebee9 Added .gitignore 2010-01-02 23:05:46 +02:00
Kristian Setälä 0d41f78da2 Fixed a little oops 2010-01-02 23:04:23 +02:00
Kristian Setälä fee03a4419 Added a README file 2010-01-02 23:03:39 +02:00
Kristian Setälä ecedbe5681 Added a simple makefile 2010-01-02 23:03:23 +02:00
Kristian Setälä 1d6f9d4cf1 The wrapper program 2010-01-02 23:02:57 +02:00
Kristian Setälä 2170545899 Added layout variant code to XKeyboard class 2010-01-02 23:01:53 +02:00
Kristian Setälä 430b9daac6 Original XKeyboard class 2010-01-02 23:01:20 +02:00