BitHeaven
/
picom
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add some TODOs 

reg_ignore is a bit complicated.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This commit is contained in:
Yuxuan Shui 2019-02-21 04:11:58 +00:00
parent d145808e69
commit 69826a0844
No known key found for this signature in database
GPG Key ID: 37C999F617EA1A47
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/win.c
View File

@ -1371,7 +1371,14 @@ finish_destroy_win(session_t *ps, win **_w) {
// Invalidate reg_ignore of windows below this one // Invalidate reg_ignore of windows below this one
// TODO what if w->next is not mapped?? // TODO what if w->next is not mapped??
// TODO seriously figure out how reg_ignore behaves.
// I think if `w` is unmapped, and destroyed after
// paint happened at least once, w->reg_ignore_valid would
// be true, and there is no need to invalid w->next->reg_ignore
// when w is destroyed.
if (w->next) { if (w->next) {
// should be `= w->reg_ignore_valid && w->next->reg_ignore_valid`,
// but keep it this way until we think about reg_ignore.
w->next->reg_ignore_valid = false; w->next->reg_ignore_valid = false;
} }

1
src/win.h
View File

@ -124,6 +124,7 @@ struct win {
win *next; win *next;
/// Pointer to the next higher window to paint. /// Pointer to the next higher window to paint.
win *prev_trans; win *prev_trans;
// TODO rethink reg_ignore
// Core members // Core members
/// ID of the top-level frame window. /// ID of the top-level frame window.