From 69826a08445039eefb57b2ceebe099301d144725 Mon Sep 17 00:00:00 2001 From: Yuxuan Shui Date: Thu, 21 Feb 2019 04:11:58 +0000 Subject: [PATCH] Add some TODOs reg_ignore is a bit complicated. Signed-off-by: Yuxuan Shui --- src/win.c | 7 +++++++ src/win.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/win.c b/src/win.c index 2b8fbd1..dc65a0b 100644 --- a/src/win.c +++ b/src/win.c @@ -1371,7 +1371,14 @@ finish_destroy_win(session_t *ps, win **_w) { // Invalidate reg_ignore of windows below this one // TODO what if w->next is not mapped?? + // TODO seriously figure out how reg_ignore behaves. + // I think if `w` is unmapped, and destroyed after + // paint happened at least once, w->reg_ignore_valid would + // be true, and there is no need to invalid w->next->reg_ignore + // when w is destroyed. if (w->next) { + // should be `= w->reg_ignore_valid && w->next->reg_ignore_valid`, + // but keep it this way until we think about reg_ignore. w->next->reg_ignore_valid = false; } diff --git a/src/win.h b/src/win.h index c3a28b7..db32a40 100644 --- a/src/win.h +++ b/src/win.h @@ -124,6 +124,7 @@ struct win { win *next; /// Pointer to the next higher window to paint. win *prev_trans; + // TODO rethink reg_ignore // Core members /// ID of the top-level frame window.