actions
/
cache
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Turning error from any to unknown

This commit is contained in:
Deepak Dahiya 2022-05-04 12:32:55 +00:00 committed by GitHub
parent cab6d27614
commit f2d5621efc
2 changed files with 19 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/restore.ts
View File

@ -4,6 +4,11 @@ import * as core from "@actions/core";
import { Events, Inputs, State } from "./constants"; import { Events, Inputs, State } from "./constants";
import * as utils from "./utils/actionUtils"; import * as utils from "./utils/actionUtils";
interface RestoreError {
name: string;
message: string;
}
async function run(): Promise<void> { async function run(): Promise<void> {
try { try {
if (!utils.isCacheFeatureAvailable()) { if (!utils.isCacheFeatureAvailable()) {
@ -52,16 +57,17 @@ async function run(): Promise<void> {
utils.setCacheHitOutput(isExactKeyMatch); utils.setCacheHitOutput(isExactKeyMatch);
core.info(`Cache restored from key: ${cacheKey}`); core.info(`Cache restored from key: ${cacheKey}`);
} catch (error: any) { } catch (error: unknown) {
if (error.name === cache.ValidationError.name) { const typedError = error as Error;
if (typedError.name === cache.ValidationError.name) {
throw error; throw error;
} else { } else {
utils.logWarning(error.message); utils.logWarning(typedError.message);
utils.setCacheHitOutput(false); utils.setCacheHitOutput(false);
} }
} }
} catch (error: any) { } catch (error: unknown) {
core.setFailed(error.message); core.setFailed((error as Error ).message);
} }
} }

15
src/save.ts
View File

@ -49,17 +49,18 @@ async function run(): Promise<void> {
uploadChunkSize: utils.getInputAsInt(Inputs.UploadChunkSize) uploadChunkSize: utils.getInputAsInt(Inputs.UploadChunkSize)
}); });
core.info(`Cache saved with key: ${primaryKey}`); core.info(`Cache saved with key: ${primaryKey}`);
} catch (error: any) { } catch (error: unknown) {
if (error.name === cache.ValidationError.name) { const typedError = error as Error;
if (typedError.name === cache.ValidationError.name) {
throw error; throw error;
} else if (error.name === cache.ReserveCacheError.name) { } else if (typedError.name === cache.ReserveCacheError.name) {
core.info(error.message); core.info(typedError.message);
} else { } else {
utils.logWarning(error.message); utils.logWarning(typedError.message);
} }
} }
} catch (error: any) { } catch (error: unknown) {
utils.logWarning(error.message); utils.logWarning((error as Error).message);
} }
} }