BitHeaven/picom
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,149 Commits 1 Branch 0 Tags 17 MiB
79fc36b3e3
Commit Graph

803 Commits

Author SHA1 Message Date
Yuxuan Shui
f64ac97a91
Return kernel count from kernel generation functions 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-09 00:45:06 +01:00
Yuxuan Shui
2239181551
Properly implement gaussian blur kernel 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-08 23:56:47 +01:00
Yuxuan Shui
fa8faaf91d
Remember the number of blur kernels 
Don't count the number of blur kernels everytime.

Fixes #188

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-07 22:21:06 +01:00
Yuxuan Shui
abb089e605
Lift the MAX_BLUR_PASS limit 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-07 07:04:50 +01:00
Yuxuan Shui
cbb859ba3c
Fix non-OpenGL build 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-06 07:40:32 +01:00
Yuxuan Shui
a18e8fcdf0
Destroy glx context created for vsync 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-06 07:33:07 +01:00
Yuxuan Shui
5e8d6bdc2d
Don't destroy glx if it's not initialized 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-06 07:27:30 +01:00
Yuxuan Shui
b947a45d71
backend_common: add blur kernel generation functions 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-06 06:56:21 +01:00
Yuxuan Shui
82b9822fd0
config: introduce new syntax for blur options. 
Parsing only, not used yet.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-06-01 00:39:00 +01:00
Yuxuan Shui
4a74b4f199
Move default values of options to config.c 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-27 23:00:12 +01:00
Yuxuan Shui
c0053d1c8a
core: delay focus updates 
Delay focus updates until critical section. Rational is that focus
events might arrive when the focused window hasn't been managed by
compton, result in that that window not being focused.

This commit makes compton mark focus update events, and only update
focus in critical section, after we managed all the new windows.

Fixes #177

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-25 00:06:41 +01:00
Yuxuan Shui
7d8a3e09be
core: just enable track_focuse 
It's not an intensive task.

Simplifies logic.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-25 00:02:25 +01:00
Yuxuan Shui
57f4a99940
win: fix focuse tracking 
Call win_on_focus_change on previous focused window too.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-24 23:34:33 +01:00
Yuxuan Shui
a2dab52334
win: remove win_unset_focus 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-24 23:32:12 +01:00
Yuxuan Shui
98d351ecf6
win: break win_set_focused into 2 functions 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-24 23:15:19 +01:00
Yuxuan Shui
51476cafa4
dbus: simplify getting focused window 
Remove find_focused

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-24 22:53:16 +01:00
Yuxuan Shui
20e60a87fa
recheck_focus doesn't need to return anything 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-24 22:40:36 +01:00
Yuxuan Shui
9c50bc58cb
core: don't refresh image when not using experimental backends 
Fixes #176

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-24 00:12:42 +01:00
Yuxuan Shui
44bea480b2
Fix build on gcc < 8 
Fixes #175

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-24 00:07:01 +01:00
Yuxuan Shui
094f00a048
Refresh stale image in critical section 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-22 22:38:22 +01:00
Yuxuan Shui
b5da914920
Mark xcb_generate_id deprecated in compton 
x_new_id is preferred since it checks for error.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 23:23:42 +01:00
Yuxuan Shui
b9a3b67f9c
new backend: xrender: fix INVER_COLOR_ALL 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 22:15:38 +01:00
Yuxuan Shui
294aae11ff
Fix xrender APPLY_ALPHA 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:22:20 +01:00
Yuxuan Shui
488db11f14
make sure backend_data is not null 
... before assigning to backend_data->ops in initialize_backend()

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:35 +01:00
Yuxuan Shui
3cabba6161
gl_common: don't use GL4 feature 
glGetIntegerv(GL_NUM_EXTENSIONS) is only available since GL4.

(However glGetStringi(GL_EXTENSIONS) is available since GL3)

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:35 +01:00
Yuxuan Shui
2d50d32bf7
new backend: glx: multiply color in APPLY_ALPHA 
Because we use pre-multiplied alpha.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:35 +01:00
Yuxuan Shui
80c7b2f7ec
new backend: glx: implement IMAGE_OP_APPLY_ALPHA 
Slight change to the backend_operations::fill interface.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:35 +01:00
Yuxuan Shui
18b1fc95ff
new backend: glx: reduce code duplication 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:35 +01:00
Yuxuan Shui
45ead409b5
new backend: glx: fix off-by-1 in blur shader generation 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:35 +01:00
Yuxuan Shui
86f4d73c22
new backend: gl_common: add support for decoupling lazy copied images 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:35 +01:00
Yuxuan Shui
b91888b0a3
new backend: glx: trivial refactoring 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:34 +01:00
Yuxuan Shui
e894105e7b
atom: fix memory leak 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:34 +01:00
Yuxuan Shui
7ed9f2884f
Fix build 2019-05-21 20:15:34 +01:00
Yuxuan Shui
18a62537ec
Add missing header file 2019-05-21 20:15:34 +01:00
Yuxuan Shui
cdb24ec99c
common.h: cleanup, cont. 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:34 +01:00
Yuxuan Shui
16ea51bbc1
common.h: more clean up 
Remove more unused stuff.

Also removed session::xinerama_scrs, since all the information we need
is covered by xinerama_scr_regs. Convert uses of xinerama_scrs to use
xinerama_scr_regs.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:34 +01:00
Yuxuan Shui
a409913c5f
common.h: remove cxfree 
Apparently XFree does take NULL.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:34 +01:00
Yuxuan Shui
939f2fb602
common.h: general clean up 
Remove unused functions and definitions. Move some macros into the files
they belong.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:34 +01:00
Yuxuan Shui
e330464126
core: acquire X compositor selection first 
Don't do anything with the overlay window with out the compositor
selection.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:33 +01:00
Yuxuan Shui
c6a4928a45
atom: cache result of get_atom 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:33 +01:00
Yuxuan Shui
76c484885d
cache: cache_get can now return error 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:33 +01:00
Yuxuan Shui
93e4a53d48
cache: fix memory leak, add missing function 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:33 +01:00
Yuxuan Shui
c08fd08ea4
Add a general key-value caching framework 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:33 +01:00
Yuxuan Shui
be673f93c6
backend: add interfaces for readiness reporting 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:33 +01:00
Yuxuan Shui
f50428a18b
core: reuse handle_new_window for pre-existing windows 
Reduce code duplication, also handle_new_window handles damage of mapped
windows properly.

Fixes #160

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:33 +01:00
Yuxuan Shui
1b00eeaf60
core: mark pre-existing window as damaged 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:33 +01:00
Yuxuan Shui
a40fdb86e1
core: unmap overlay window when we first acquire it 
It used to be unmap when we receive its MapNotify, but now since we discard
events received before we grab X server, that event it lost. But it
turns out we can just unmap it when it's first created, no need to wait
for the MapNotify.

Partially fix #160

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:32 +01:00
Yuxuan Shui
ad8211e341
event: handle reparent to the same parent 
When a window is reparented to the same parent again, we should just
move it to the top of the stack, instead of add it again.

Also a slight refactor restack_win.

Fixes #164

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:32 +01:00
Yuxuan Shui
cfbd1819ed
core: only grab X server when there indeed is new windows 
Shouldn't grab X server for nothing.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:32 +01:00
Yuxuan Shui
46b8eb8d4d
core: handle configure notify of unmanaged window 
Important for window stacking.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:32 +01:00
Yuxuan Shui
9ed1b985c5
core: don't try rebinding the window image when unredirected 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:32 +01:00
Yuxuan Shui
efe63f5380
fix nogl build 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:32 +01:00
Yuxuan Shui
468fb637b6
new backends: xrender: fix memory leak 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:32 +01:00
Yuxuan Shui
f93f697759
Remove several unnecessary experimental_backends check 
Window flags can be set whichever backend we use, we will ignore then in
paint_preprocess. free_paint can be called whichever backend we use,
they just do nothing if we use experimental backends.

Others should rather just check if backend_data is NULL.

Making the code slightly more understandable, also making the eventual
removal of these checks easier.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:31 +01:00
Yuxuan Shui
8e5210cb9c
new backend: glx: use glFinish instead of glXWaitGL 
The API document claims they achieve the same thing, apparently not.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:31 +01:00
Yuxuan Shui
c55088944a
new backend: glx: use glFinish/glXWaitGL if not on NVIDIA 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:31 +01:00
Yuxuan Shui
b35bfd07d1
backend: driver: fix string out-of-bound read 
libxcb doesn't null terminate strings.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:31 +01:00
Yuxuan Shui
197e9dc866
auto enable sync fence for NVIDIA driver users 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:31 +01:00
Yuxuan Shui
685a583f84
backend: add preliminary support for driver detection 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:31 +01:00
Yuxuan Shui
a2d0d5c826
xrender: move into its own folder 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:31 +01:00
Yuxuan Shui
5069193893
core: mark newly created window as damaged 
Damage could have already happened at the time we call fill_win on a new
window. It's too difficult, or impossible, for us the find out if that
happened. So just blindly mark window as damaged.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:31 +01:00
Yuxuan Shui
d4fde6a392
core: wait for the result xcb_grab_server before doing anything 
Make sure X grab server is finished before calling x_discard_events in
session_init. Otherwise x_discard_events won't be able to discard all of
the events that were sent before we grab the server.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:30 +01:00
Yuxuan Shui
3d2217a112
event: promote several logs to log level debug 2019-05-21 20:15:30 +01:00
Yuxuan Shui
0753eaacf8
Map newly created window in handle_new_window 
A window might be mapped before we had the chance to start managing it.
So check to see if we should map a window after we call fill_win on it.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:30 +01:00
Yuxuan Shui
58944f36ce
Delay window managing 
Create a "critical section" in draw_callback by grabbing the X server.
Delay the managing of newly created windows until we enter the cricial section.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:30 +01:00
Yuxuan Shui
927cdd8652
win: handle destruction of unmanaged window 
Previous destructions of unmanaged window are silently ignored, causing
windows with duplicated IDs.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:30 +01:00
Yuxuan Shui
883d8c9142
x: add x_discard_events 
Also, during session_init, discard old events after we grab the server.
If we don't do that, old, out dated CreateNotify will cause us to add
the window with the same id multiple times. Here is an explanation of
how that could happen:

1. compton connects to X
2. a new window created by someone else, X send us a CreateNotify
3. compton is initializing, so it didn't handle the event.
4. compton pulls a list of all windows from X. This will include that
   window created in (2)
5. compton starts to handle event. it will handle the CreateNotify sent
   in (2), thus adds the same window twice.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:30 +01:00
Yuxuan Shui
0c992b11d3
win: add assert to catch duplicated windows 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:30 +01:00
Yuxuan Shui
452e313c64
kernel: tweak gaussian deviation 
So that the shadow doesn't look cut off or fuzzy.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:30 +01:00
Yuxuan Shui
eb2b0a6fa1
win: fix add_win_top 
Instead of reusing add_win_above with the id of the window on the top
of the stack, we create a new function that takes a list_node.

Fix a problem when the window on the top of the stack is destroyed. Because
add_win_above search for windows from the hash table, it won't find that window
and returns NULL.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:29 +01:00
Yuxuan Shui
dfd9ecf5c9
core: fix use-after-free in session_init 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:29 +01:00
Yuxuan Shui
a96cdc7e15
win: fix an invalid cast from struct win to managed_win 
Should always check if win::managed is true first.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:29 +01:00
Yuxuan Shui
bd4c242015
win: split struct win 
Currently compton handles window creation event by immediately query all
the information it needs and create a window struct with that
information. However, this is prone to race conditions.

In the future, we want to react to window creation event by creating a
placeholder in the window stack, and only query window information in a
critical section where the X server is grabbed by us.

This commit split struct win into two struct, one as placeholder, the
other for holding actual window information.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:29 +01:00
Yuxuan Shui
27603343a1
list: add list_replace 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:29 +01:00
Yuxuan Shui
aee496aeff
build: look for libev via pkgconfig 
FreeBSD has pkg-config files for libev

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:29 +01:00
Yuxuan Shui
41fd229230
build: check if std-predef.h exists 
Fix build on FreeBSD / non-glibc systems

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:28 +01:00
Yuxuan Shui
85dba1f3c9
core: don't paint window with image errors 
Previously we do window image update _after_ the to_paint checks.
Therefore the window image might failed to update after we decided to
paint it.

Do window image update before the checks.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:28 +01:00
Yuxuan Shui
a6decc3a0f
list.h: remove restrict qualifier 2019-05-21 20:15:28 +01:00
Yuxuan Shui
4afc853d4f
Advertise ourselves as compton to X 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:28 +01:00
Yuxuan Shui
abeeb36bb2
x: wrap xcb_generate_id to check for errors 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:28 +01:00
Yuxuan Shui
8cfa750a6d
config: fix grammar 2019-05-21 20:15:28 +01:00
Yuxuan Shui
c54b2c0277
win: add new type window_stack_entry 2019-05-21 20:15:28 +01:00
Yuxuan Shui
5077d56676
Refactor linked-list operations into a header 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:28 +01:00
Yuxuan Shui
b9f894c4fc
win: handle restack to bottom correctly 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:27 +01:00
Yuxuan Shui
166ec55778
win: keep a prev pointer 
Save us some iteration when updating the window stack

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:27 +01:00
Yuxuan Shui
a68903b9ef
win: track windows with a hash table 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:27 +01:00
Yuxuan Shui
3935e97e69
gl_common: bump GL to 3.30 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:27 +01:00
Yuxuan Shui
6e8a86d415
gl_common: use vao 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:27 +01:00
Yuxuan Shui
ffc9c32b5e
gl_common: update gl_compose to core profile 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:27 +01:00
Yuxuan Shui
f08004a448
gl_common: update gl_blur to core profile 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:27 +01:00
Yuxuan Shui
599e8b6600
gl_common: update gl_fill to core profile 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:27 +01:00
Yuxuan Shui
233edbd1c3
gl_common: fix implicit conversion warnings 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:26 +01:00
Yuxuan Shui
7c2edd9d63
gl_common: remove some fixed function glEnable/Disable 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:26 +01:00
Yuxuan Shui
d64aab7d40
gl_common: add vertex shader 
Also use an attribute for the texture coordinates.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:26 +01:00
Yuxuan Shui
18f6a20bf4
new backend: fix crash when window's shadow state change 
Create a shadow image for a mapped window when it's shadow become enabled.
For unmapped window, the shadow image is created during mapping. Also,
if the window has IMAGE_ERROR flag, it won't be render anyway. So shadow
image won't be created in that case either.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:26 +01:00
Yuxuan Shui
eeb8712982
Add debug prints to win_determine_shadow 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:26 +01:00
Yuxuan Shui
2040190fb6
utils: improve CHECK() macro 
Include the original expression in the assertion failure message.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:26 +01:00
Yuxuan Shui
0733f7540f
Silence unused variable warning in release build 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:26 +01:00
Yuxuan Shui
63dd16ebac
Use int in margin_t 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:25 +01:00
Yuxuan Shui
9677750e3d
Improve checked cast macros 
to_{int,char,i16}_checked now works with unsigned types (except
uint64_t).

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
 2019-05-21 20:15:25 +01:00