bbb73fe64e
Fix integer overflow
...
`x + wid` will convert x to unsigned first, if x < 0, integer overflow
could occur.
2018-10-12 23:17:12 +01:00
de6e2f5792
Merge branch 'less-xlib' into next
...
Closes #14
2018-10-10 10:55:21 +01:00
9bb3327549
Die when the X11 connection breaks
...
With libX11, the library calls an I/O error handler if the connection to
the server breaks. The default I/O error handler prints an error message
and calls exit(). This can be seen when running a "pre-xcb" compton
against Xephyr and then closing the Xephyr window:
XIO: fatal IO error 11 (Resource temporarily unavailable) on X server ":1"
after 241 requests (241 known processed) with 0 events remaining.
The current compton would just continue running. After this commit, it
instead exits with this message:
handle_queued_x_events(): X11 server connection broke (error 1)
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:54:05 +01:00
1c1adc96c8
Change event masks to XCB defines
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:54:05 +01:00
37ef9c5b8a
Add the xcb_connection_t to session_t
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-10-10 10:54:00 +01:00
54807342f4
Convert XQueryTree to XCB
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:50:00 +01:00
6c6156932f
Convert find_client_win() to XCB
...
This function was the only caller of wid_get_children() which called
XQueryTree().
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:50:00 +01:00
b2bfbcdfb0
Convert XGetAtomName to XCB
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-10-10 10:49:52 +01:00
ca148c8f15
Fix printf format with DEBUG_EVENTS
...
Xlib uses unsigned long for XIDs, but xcb always uses uint32_t. Thus,
this needs the format string for uint32_t now.
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:46:39 +01:00
7e71f46401
Convert XInternAtom to XCB
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-10-10 10:46:34 +01:00
2da0ecdf66
Convert XSelectInput() to XCB
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-10-10 10:42:12 +01:00
1b1b3456bc
Convert XGetSelectionOwner to XCB
...
This also fixes a memory leak: buf was not freed if another composite
manager was already running.
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
2dc90e7d4d
Convert XGetInputFocus to XCB
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
8db6473d32
Convert property management to XCB
...
I removed the error checking in compton.c because it was dead code.
XChangeProperty() always returns 1.
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
a192bfb130
Replace XSetSelectionOwner with XCB
...
Note that the argument order is different between Xlib and XCB.
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
0cae42faaa
Replace XDestroyWindow with xcb_destroy_window
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
e30ff25dd3
Replace XClearArea with xcb_clear_area
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
28e9488e25
XCBify XCreateGC and XFreeGC
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
b86190452c
XCBify X{Ung,G}abServer
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
3c5d7555a4
XCBify X{Unm,M}apWindow
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-10 10:41:40 +01:00
6a8df0ada7
Fix a leak of XFIXES regions
2018-10-09 22:24:00 +01:00
9654d0bb64
More license stuff...
2018-10-04 11:18:09 +01:00
7b755a3cf0
Fix typo in CONTRIBUTORS, move licenses around
...
Having a LICENSE file makes github happy
2018-10-03 22:24:12 +01:00
ee318582f5
Sort out license problems
...
IANAL, but I think I am allowed to add missing copyright notices for
someone else. And I did my best job using git history to figure out who
wrote which functions. So I hope everything is fine.
2018-10-03 22:14:51 +01:00
9e1422dc90
Fix parsing of shadow-exclude-reg
...
Closes #13
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-10-03 18:20:40 +01:00
f1872c4033
Allocation for xinerama_scr_regs used wrong size
...
Should be sizeof(region_t). Rebasing is hard :(
2018-10-03 16:19:48 +01:00
ff5a0cc0b7
Update README
2018-10-03 01:09:37 +01:00
2a4fed50f4
Use libev for inputs and timeouts
...
Bugs:
* There seems to be a noticeable frame loss when window
is being opened/closed. But the same problem also exists
in master/next, so this is not a regression.
* Using --sw-opti and --benchmark at the same time causing
compton to draw more frequently than permitted by the
arguments. That is because the sleep interval calculation
is flawed. Not really a regression either.
Verified still working:
* Usual painting
* Fade
* Benchmark mode
* --sw-opti (with or without benchmark mode)
* DBus
* Unredir delay
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-10-03 01:05:32 +01:00
e58de49d7a
Merge pull request #10 from psychon/remove-xfixes
...
Some more trivial Xlib -> XCB conversions
2018-10-02 21:38:28 +01:00
d917ec22a8
Fix a typo in conversion to xcb damage
2018-10-02 21:25:09 +01:00
385ba2cdf6
Remove unused definition
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-02 19:56:47 +02:00
cad786c025
Remove include of X11/Xutil.h
...
It doesn't seem to cause any problems. Perhaps its uses were already
converted to XCB?
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-02 19:54:20 +02:00
bc7767e086
Replace Xlib atom constants with XCB ones
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-02 19:53:28 +02:00
b2d947a19a
Remove include of Xfixes.h
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-02 19:51:37 +02:00
91468c3622
Replace BadRegion with XCB_XFIXES_BAD_REGION
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-02 19:51:30 +02:00
7c174cc3b1
Replace XserverRegion with xcb_xfixes_region_t
...
Signed-off-by: Uli Schlachter <psychon@znc.in>
2018-10-02 19:50:27 +02:00
cb99618eb6
More sanitiziers
...
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-10-01 14:54:11 +01:00
8be2cbf1a5
Update README
...
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-10-01 14:30:55 +01:00
024eea29ec
Remove unused cmake files
...
We might switch to a proper configure system later.
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 21:35:17 +01:00
cb4bab1cf6
Print deprecation warning for removed OpenGL options
...
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 21:07:29 +01:00
03f33ed45c
Move a couple X related functions to x.c
...
Also replace remaining Pixmap with xcb_pixmap_t
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 20:57:42 +01:00
ddab20176b
Fix building with ENABLE_XRESCHECK=1
2018-09-30 20:43:34 +01:00
18022181ee
Make sure to clear the rectangles
2018-09-30 20:41:30 +01:00
6a41bebfa5
Just clear shadow anyways
...
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 20:12:06 +01:00
97cd3421b0
Remove last bits of Xfixes
...
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 15:54:12 +01:00
e0bc6f5f7c
Add helper macros for calling xcb function and wait for reply
...
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 15:54:12 +01:00
ff27ca4072
Move xerror_common to x.c
...
Also rename it to x_print_error
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 15:54:12 +01:00
915839c3d3
Convert XFixesCreateRegionFromWindow to use Shape directly
...
Fetch the rectangles directly use the Shape extension.
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 15:54:12 +01:00
82e63593ae
region.h: helper functions for converting rect types
...
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 15:54:12 +01:00
a7d50ffdb2
Remove unused function rect_crop
...
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
2018-09-30 15:54:12 +01:00
Yuxuan Shui