Misc #163: Make usage of glFinish() optional

Make usage of glFinish() optional to avoid high CPU usage. (#163)
This commit is contained in:
Richard Grenville 2013-12-26 20:43:06 +08:00
parent 9e053910f2
commit 3e783f3e1e
2 changed files with 13 additions and 2 deletions

View File

@ -513,6 +513,9 @@ typedef struct {
bool dbe; bool dbe;
/// Whether to do VSync aggressively. /// Whether to do VSync aggressively.
bool vsync_aggressive; bool vsync_aggressive;
/// Whether to use glFinish() instead of glFlush() for (possibly) better
/// VSync yet probably higher CPU usage.
bool vsync_use_glfinish;
// === Shadow === // === Shadow ===
/// Enable/disable shadow for specific window types. /// Enable/disable shadow for specific window types.

View File

@ -1905,7 +1905,10 @@ paint_all(session_t *ps, XserverRegion region, XserverRegion region_real, win *t
XSync(ps->dpy, False); XSync(ps->dpy, False);
#ifdef CONFIG_VSYNC_OPENGL #ifdef CONFIG_VSYNC_OPENGL
if (ps->glx_context) { if (ps->glx_context) {
glFinish(); if (ps->o.vsync_use_glfinish)
glFinish();
else
glFlush();
glXWaitX(); glXWaitX();
} }
#endif #endif
@ -1939,7 +1942,10 @@ paint_all(session_t *ps, XserverRegion region, XserverRegion region_real, win *t
#ifdef CONFIG_VSYNC_OPENGL #ifdef CONFIG_VSYNC_OPENGL
case BKEND_XR_GLX_HYBRID: case BKEND_XR_GLX_HYBRID:
XSync(ps->dpy, False); XSync(ps->dpy, False);
glFinish(); if (ps->o.vsync_use_glfinish)
glFinish();
else
glFlush();
glXWaitX(); glXWaitX();
paint_bind_tex_real(ps, &ps->tgt_buffer, paint_bind_tex_real(ps, &ps->tgt_buffer,
ps->root_width, ps->root_height, ps->depth, ps->root_width, ps->root_height, ps->depth,
@ -5421,6 +5427,7 @@ get_cfg(session_t *ps, int argc, char *const *argv, bool first_pass) {
{ "unredir-if-possible-exclude", required_argument, NULL, 308 }, { "unredir-if-possible-exclude", required_argument, NULL, 308 },
{ "unredir-if-possible-delay", required_argument, NULL, 309 }, { "unredir-if-possible-delay", required_argument, NULL, 309 },
{ "write-pid-path", required_argument, NULL, 310 }, { "write-pid-path", required_argument, NULL, 310 },
{ "vsync-use-glfinish", no_argument, NULL, 311 },
// Must terminate with a NULL entry // Must terminate with a NULL entry
{ NULL, 0, NULL, 0 }, { NULL, 0, NULL, 0 },
}; };
@ -5668,6 +5675,7 @@ get_cfg(session_t *ps, int argc, char *const *argv, bool first_pass) {
// --write-pid-path // --write-pid-path
ps->o.write_pid_path = mstrcpy(optarg); ps->o.write_pid_path = mstrcpy(optarg);
break; break;
P_CASEBOOL(311, vsync_use_glfinish);
default: default:
usage(1); usage(1);
break; break;